Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test-fetch-content-recompile in macOS #88

Closed
gonzaponte opened this issue Aug 17, 2023 · 2 comments
Closed

Fix test-fetch-content-recompile in macOS #88

gonzaponte opened this issue Aug 17, 2023 · 2 comments

Comments

@gonzaponte
Copy link
Collaborator

This test ensures that when a project includes nain4 via FetchContent, it can recompile without the need for an internet connection. This test works fine in ubuntu, but the command used in the test to prevent network connections (iptables) does not exist in macOS (or maybe it does, but it would need to be installed). With #82 we finally got macOS working in GHA. During the process, we realized that the test was passing on macOS when it shouldn't. The reasons for this are:

  1. The command iptables failed, but the bash script continued running
  2. Because iptables failed, no network restrictions were applied, which would have made the test fail

For 1. we attempted a5f796f, but it didn't seem to have an effect (which should also need to be investigated). For 2. a first attempt based on pfctl was unsuccessful as GHA was getting stuck on that command (I believe).

@gonzaponte gonzaponte mentioned this issue Aug 17, 2023
jacg added a commit that referenced this issue Aug 17, 2023
It's not crucial, and preventing us from doing serious work.

See #88
@jacg
Copy link
Owner

jacg commented Aug 17, 2023

I've disabled this test in 4d4aa78, for now.

@jacg
Copy link
Owner

jacg commented Nov 1, 2023

This is irrelevant now that we have migrated from cmake to meson.

@jacg jacg closed this as completed Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants