You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This test ensures that when a project includes nain4 via FetchContent, it can recompile without the need for an internet connection. This test works fine in ubuntu, but the command used in the test to prevent network connections (iptables) does not exist in macOS (or maybe it does, but it would need to be installed). With #82 we finally got macOS working in GHA. During the process, we realized that the test was passing on macOS when it shouldn't. The reasons for this are:
The command iptables failed, but the bash script continued running
Because iptables failed, no network restrictions were applied, which would have made the test fail
For 1. we attempted a5f796f, but it didn't seem to have an effect (which should also need to be investigated). For 2. a first attempt based on pfctl was unsuccessful as GHA was getting stuck on that command (I believe).
The text was updated successfully, but these errors were encountered:
This test ensures that when a project includes
nain4
viaFetchContent
, it can recompile without the need for an internet connection. This test works fine in ubuntu, but the command used in the test to prevent network connections (iptables
) does not exist in macOS (or maybe it does, but it would need to be installed). With #82 we finally got macOS working in GHA. During the process, we realized that the test was passing on macOS when it shouldn't. The reasons for this are:iptables
failed, but the bash script continued runningiptables
failed, no network restrictions were applied, which would have made the test failFor 1. we attempted a5f796f, but it didn't seem to have an effect (which should also need to be investigated). For 2. a first attempt based on
pfctl
was unsuccessful as GHA was getting stuck on that command (I believe).The text was updated successfully, but these errors were encountered: