Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issues related to FieldPredicates class #368

Closed
dasteg opened this issue Aug 28, 2019 · 0 comments
Closed

Performance issues related to FieldPredicates class #368

dasteg opened this issue Aug 28, 2019 · 0 comments
Milestone

Comments

@dasteg
Copy link
Contributor

dasteg commented Aug 28, 2019

The method FieldPredicates.named(string) has a major performance issue. The predicate compiles the name to regex pattern inside the test method. This makes it extremely slow when creating a large number of randomized objects.

Pattern is immutable and thread-safe and can be compiled before creating the predicate. This reduces execution time a lot and also saves quite some memory garbage.

created a pull request #367

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants