Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate design or html from javascript - dont use javascript new to make new elements #121

Closed
mohamedsharaf opened this issue Jan 22, 2015 · 3 comments
Labels
question Further information is requested
Milestone

Comments

@mohamedsharaf
Copy link
Contributor

as in title

may use javascript template engine or better use html

sot it can be easier to change the design

i will have search in java script template frameworks and post here
hope you take this decision fast as kineticjs

thanks and keep the good work

@ivmartel ivmartel added question Further information is requested and removed question Further information is requested labels Jan 22, 2015
@ivmartel
Copy link
Owner

Could you show or link to some code that does not follow this principle?
I try to group the gui code in the viewer specific appgui.js file. From there you can override most of the html element creating code.

@ivmartel ivmartel added question Further information is requested and removed question Further information is requested labels Feb 12, 2015
@ivmartel
Copy link
Owner

Hi Mohamed, not sure if you saw the latest commits but I think they go the same way as this issue. Integrating dwv in a web page is now way simpler as you can see in this fiddle: http://jsfiddle.net/ivmartel/LteeL0gf/

@ivmartel ivmartel added the question Further information is requested label Mar 4, 2015
@ivmartel ivmartel added this to the 0.9.0 milestone Mar 4, 2015
@ivmartel
Copy link
Owner

ivmartel commented Mar 4, 2015

On the path towards clean design! See #124...

@ivmartel ivmartel closed this as completed Mar 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants