Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

my changing dictionary is shown duplicated in the Dictionaries tab #152

Closed
ildar opened this issue Jan 16, 2023 · 19 comments
Closed

my changing dictionary is shown duplicated in the Dictionaries tab #152

ildar opened this issue Jan 16, 2023 · 19 comments

Comments

@ildar
Copy link

ildar commented Jan 16, 2023

I'm making and updating my own small dictionary and put it in Android.
That worked well. But I found that the dictionary is shown ~7 times in the Dictionaries tab.

I guess that various versions of a dictionary get different uuids (calculated) hence later versions accepted as a new dict.

@itkach
Copy link
Owner

itkach commented Jan 18, 2023

Indeed, every new .slob gets a new uuid. They may have the same label, but are distinct. Dictionaries with the sameuri tag are understood to provide content in the same collection, same "logical" dictionary (meaning that articles from that dictionary are first in the lookup result when following links).
I'm not sure if there's an issue or a question here - if you don't need older versions of your dictionary just remove them manually.

@ildar
Copy link
Author

ildar commented Jan 18, 2023 via email

@itkach
Copy link
Owner

itkach commented Jan 18, 2023

bookmarks and history are not strictly bound to slob by uuid, if your dictionaries have uri tag and it remains the same across versions bookmarks and history should continue to work.

@ildar
Copy link
Author

ildar commented Jan 18, 2023 via email

@itkach
Copy link
Owner

itkach commented Jan 18, 2023

why are you trying to delete them? this is internal app data, you're not supposed to mess with it. You "forget" (trash can icon) dictionaries is Dictionary tab in UI.

@ildar
Copy link
Author

ildar commented Jan 18, 2023 via email

@itkach
Copy link
Owner

itkach commented Jan 18, 2023

still, why are you looking at internal app data? what is the actual issue you are trying to solve?

@ildar
Copy link
Author

ildar commented Jan 18, 2023 via email

@itkach
Copy link
Owner

itkach commented Jan 18, 2023

Well, they don't come back from bookmarks or history, I'm pretty sure. I am unable to reproduce this at all, if I forget a dictionary - it's gone from the app. Dictionary files of course stay where they are unless user deletes them themselves, but there is no way for them to just show up (or come back) in the app

@ildar
Copy link
Author

ildar commented Jan 24, 2023 via email

@itkach
Copy link
Owner

itkach commented Jan 25, 2023

I will look into this.

@itkach
Copy link
Owner

itkach commented Feb 19, 2023

@ildar can you pls try this commit: bd227cb ?

@ildar
Copy link
Author

ildar commented Feb 19, 2023 via email

@itkach
Copy link
Owner

itkach commented Feb 19, 2023 via email

@ildar
Copy link
Author

ildar commented Feb 19, 2023 via email

@itkach
Copy link
Owner

itkach commented Feb 19, 2023 via email

@itkach
Copy link
Owner

itkach commented Feb 19, 2023

@ildar here's apk (unzip first) aard2-android-debug.apk.zip

@ildar
Copy link
Author

ildar commented Feb 20, 2023 via email

@itkach
Copy link
Owner

itkach commented Mar 7, 2023

fixed in bd227cb

@itkach itkach closed this as completed Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants