Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uploadFiles leaks memory #499

Closed
ainth opened this issue Jun 5, 2018 · 1 comment
Closed

uploadFiles leaks memory #499

ainth opened this issue Jun 5, 2018 · 1 comment

Comments

@ainth
Copy link

ainth commented Jun 5, 2018

In RNFSManager.m in uploadFiles the new upload job is added to the self.uploaders dictionary. Jobs are never cleaned up and when uploading a large number of large files this will eventually crash the device (as in our case) as it seems the body of the request is retained.

I've confirmed this in xcode's instruments where I see NSMutableData objects being retained that are created from uploadFiles that are persisted and never get cleaned up.
@Ignigena Ignigena mentioned this issue Jun 8, 2018
Merged
@itinance
Copy link
Owner

itinance commented Jun 9, 2018

Fixed by #502

@itinance itinance closed this as completed Jun 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ainth @itinance