Skip to content
This repository has been archived by the owner on Sep 13, 2023. It is now read-only.

Add new DVC extra #633

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Add new DVC extra #633

merged 1 commit into from
Mar 10, 2023

Conversation

mike0sv
Copy link
Contributor

@mike0sv mike0sv commented Mar 9, 2023

No description provided.

@mike0sv mike0sv requested a review from a team as a code owner March 9, 2023 20:35
@mike0sv mike0sv temporarily deployed to internal March 9, 2023 20:35 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ffb2047) 86.09% compared to head (4cb751f) 86.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #633   +/-   ##
=======================================
  Coverage   86.09%   86.09%           
=======================================
  Files         107      107           
  Lines        9733     9733           
=======================================
  Hits         8380     8380           
  Misses       1353     1353           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aguschin aguschin merged commit d2100ac into main Mar 10, 2023
@aguschin aguschin deleted the fix/new-dvc-extra branch March 10, 2023 03:06
@@ -110,6 +110,7 @@
"webdav",
"webhdfs",
"webhdfs_kerberos",
"lint",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed? We usually move these things around without a guarantee that they will always work or be available (other than remote related extras).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to enable pip install mlem[dvc-s3] and ones like that. We have a test that checks we didn't miss anything, that's why we need to add keep it here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, I think we should've added it here instead

if e not in {"all", "dev", "terraform", "tests", "testing"}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doing that in #634

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants