Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider a better general term than "ztunnel" for ambient's node proxy #15232

Open
ilrudie opened this issue Jun 3, 2024 · 4 comments
Open

Comments

@ilrudie
Copy link
Contributor

ilrudie commented Jun 3, 2024

ztunnel is really an implementation detail in the ambient architecture. Presently there isn't really another implementation of the layer 4 node proxy but that is potentially not always true. Additionally, at present ztunnel really only acts as the node proxy but that again is hot a hard and fast rule. Nothing really prevents it from being deployed as a sidecar sometime down the road if we find an interesting use for that architecture for instance.

To those outside of the Istio development stream ztunnel also doesn't mean all that much. Consider trying to describe sidecar Istio to someone who may not know that much about the implementation of a service mesh but the term you have available is just "envoy".

@craigbox
Copy link
Contributor

craigbox commented Jun 4, 2024

(Bikeshed warning)

I think the problem here is one of there not being a way to describe the two different potential traffic flows in "ambient mode"

  • ztunnel only
  • ztunnel and waypoint

We sometimes use "secure L4 overlay" mode to describe the first one. It's two words too many.

If we standardised on something like

  • ambient mode
  • waypoint mode

we would then have to talk about the "node proxy" when you're referring to the thing that enforces the L4 policy, for example.

(noting that @louiscryan would prefer "ambient/waypoint mode") we should almost never have to say "ztunnel" except when talking about configuring/using Istio's reference implementation of the node proxy

@ilrudie
Copy link
Contributor Author

ilrudie commented Jun 4, 2024

Ambient enabled == no waypoint
Ambient enhanced == with a waypoint

@bleggett
Copy link
Contributor

bleggett commented Jun 5, 2024

👍 on not using "ztunnel" in architecture documents.

  • node proxy (preferred, it describes (location) (function) which is enough)
  • L4 proxy

We only need terms to describe our current usages.

@ilrudie
Copy link
Contributor Author

ilrudie commented Jun 5, 2024

Some general thoughts translated from the ambient wg meeting discussion

  • node proxy was not really strong disliked and gels pretty well with other terminology
  • l4 proxy had some push back

istio- prefix could be added but in the context of Istio documentation that is probably not necessary
ambient- prefix could be added but it may imply that a waypoint somehow isn't ambient and is also likely redundant so was not well received

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants