Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

page tests for chinese translated pages #15213

Open
dhawton opened this issue May 31, 2024 · 1 comment
Open

page tests for chinese translated pages #15213

dhawton opened this issue May 31, 2024 · 1 comment

Comments

@dhawton
Copy link
Member

dhawton commented May 31, 2024

I see we are displaying the translated pages as being tested (ie, https://istio.io/latest/zh/docs/ambient/install/helm-installation/), but there aren't any generated snips or tests, and the tests themselves are only triggered when content/en/docs/.*(test\.sh|snips\.sh) is matched in PRs (English docs only).

Is there any previous historical context I might be missing on why we aren't generating snips and testing these pages as well, or changing the test header to no or is this an oversight that should be corrected? Seems to me that if we're marking the pages as tested, we should be testing them.

@craigbox
Copy link
Contributor

craigbox commented Jul 2, 2024

How do our Chinese maintainers feel about this?
@kebe7jun @wilsonwu @zirain to pick a random set

The easiest approach is to remove the testing indicator for /zh/ pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants