Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

have build container only claim port 1313 if running make serve #15199

Open
craigbox opened this issue May 30, 2024 · 2 comments
Open

have build container only claim port 1313 if running make serve #15199

craigbox opened this issue May 30, 2024 · 2 comments

Comments

@craigbox
Copy link
Contributor

craigbox commented May 30, 2024

You can only run the build container once, because it port-forwards port 1313.

Makefile.overrides.mk:CONTAINER_OPTIONS = -p 1313:1313 ${ADDITIONAL_CONTAINER_OPTIONS}

This is only necessary if you're using it to run a local Hugo preview, and it stops you being able to do useful things like make gen or make lint-md while it's running.

Is it practical to run this container more than once at once, and if so, can we have this variable only set when the target for make serve is run?

Affected product area (please put an X in all that apply)

[x] Docs
[x] Test and Release

@zirain
Copy link
Member

zirain commented May 30, 2024

is this for istio.io repo?

@craigbox
Copy link
Contributor Author

Yes, sorry, I thought it was one of the common files. I'll move the issue to the right repo!

@craigbox craigbox transferred this issue from istio/istio May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants