Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stablemultidiffusion_pipeline.py code is incomplete about the code that does not apply to the lcm method. Can you provide a copy? #11

Open
redredbluee opened this issue May 16, 2024 · 8 comments

Comments

@redredbluee
Copy link

stablemultidiffusion_pipeline.py code is incomplete about the code that does not apply to the lcm method. Can you provide a copy? there is something wrong with the scheduler

@ironjr
Copy link
Owner

ironjr commented May 16, 2024

Ah, yes. I do have a plan to support other types of acceleration LoRAs (I'm trying Hyper-SD right now).

If you have a list of request for other types of schedulers, please let me know. Thanks!

@redredbluee
Copy link
Author

DDIMScheduler

Ah, yes. I do have a plan to support other types of acceleration LoRAs (I'm trying Hyper-SD right now).

If you have a list of request for other types of schedulers, please let me know. Thanks!

Ah, yes. I do have a plan to support other types of acceleration LoRAs (I'm trying Hyper-SD right now).

If you have a list of request for other types of schedulers, please let me know. Thanks!

not using any acceleration, I want to use the normal pipeline with DDIMScheduler, 20-50 step. But the code currently does not support. Does this algorithm require an acceleration solution?

@ironjr
Copy link
Owner

ironjr commented May 16, 2024

Ah the algorithm is originally about acceleration stuff, but I will include other standardized samplers as well.
Thanks for the feedback. The update won't take so long.

@redredbluee
Copy link
Author

Ah the algorithm is originally about acceleration stuff, but I will include other standardized samplers as well. Thanks for the feedback. The update won't take so long.

This algorithm is great. When the mask area is small during inpainting, I wanted a more detailed and controlled generation, while the result is a bit rough. I'm wandering whether the acceleration affects.

@andupotorac
Copy link

Curious if you manage to add support to LCM-LORA. I see this is already supported in the original StreamDiffusion, so shouldn't it work here as well?

@ironjr
Copy link
Owner

ironjr commented May 30, 2024

LCM-LoRA's already in support, though I have found that LCM-SDXL has lower quality and relatively severe style leakage issues compared to newer acceleration modules (Lightning/Hyper-SD/etc...). It'll be nice if you suggest more acceleration methods, so I can put them into this :)
And... I am sorry for the late update of DDIMSampler. This should be my top priority.

@andupotorac
Copy link

Sure, here are a few accelerators:

  • PCM (code not yet live)
  • TCD
  • DMD2

Also check OneDiff, FaserLCM, DeepCache, if these are useful.

@ironjr
Copy link
Owner

ironjr commented May 31, 2024

Copy that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants