make deprecated shell_streams writable #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shell_streams is deprecated, but keep it working with deprecation warnings instead of breaking it and handle debugpy_stream being undefined, since allow_none is True
|
LGTM! |
and start handling them in `.start()` instead of `__init__`
|
Added one more handling of optional new functionality: when control_thread is undefined, control messages would never be handled. This starts handling control messages, on whichever loop they are defined. |
I like that the add_callback is now called in the start function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shell_streams is deprecated, but keep it working with deprecation warnings instead of breaking it
and handle debugpy_stream being undefined, since allow_none is True
This is part of avoiding breakage in ipyparallel to smooth the transition.