Use channel get_msg helper method #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing tests timed out, and they are using jupyter_client 6.1.12, so I am not sure what is the reason. |
|
Trigger CI |
davidbrochart
force-pushed
the
fix_get_msg
branch
from
d1c2782
to
9aaf90a
Compare
davidbrochart
force-pushed
the
fix_get_msg
branch
from
41f39dc
to
9f78f55
Compare
|
This is now ready to review/merge. |
tschaume
added a commit
to tschaume/kernel_gateway
that referenced
this pull request
Aug 21, 2021
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Oct 25, 2021
https://build.opensuse.org/request/show/925994 by user bnavigator + dimstar_suse - Allow updating to jupyter_client 7 through backporting gh#ipython/ipykernel#634 and gh#ipython/ipykernel#736 to ipykernel-pr634+736-remove-block-client7.patch - Update to 5.5.6 * Add ipython_genutils dependency - Block updating to jupyter_client 7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use e.g.
kc.get_shell_msg()instead ofkc.shell_channel.get_msg(), because the latter is now always async in jupyter_client. The former is a higher-level method that runsget_msg()until complete for a blocking client.