-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable ipnisync to be served over libp2p. #400
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #400 +/- ##
==========================================
- Coverage 50.15% 50.00% -0.16%
==========================================
Files 61 61
Lines 5022 5062 +40
==========================================
+ Hits 2519 2531 +12
- Misses 2185 2214 +29
+ Partials 318 317 -1
☔ View full report in Codecov by Sentry. |
581fccd
to
e916156
Compare
925ab59
to
8b9eef0
Compare
d680791
to
46f6c2f
Compare
This should allow index providers such as boost to disable publishing over data-transfer/graphsync and be able to publish over libp2p without having to do any other configuration.
- Update comments - Use latest go-libp2p
46f6c2f
to
732924d
Compare
This allows all index-providers to upgrade without any changes to their configuration or any changes to infrastructure.
Changes
After upgrade, index-providers will start serving ipnisync and stop using data-transfer/graphsync to serve advertisements.
New Engine Options and Config
WithHttpNoLibp2p
: If true, disables serving HTTP over libp2p and only serves plain HTTP.config.Ingest.HttpPublisher.NoLibp2p
: NoLibp2p disables serving HTTP over libp2p if true. Set this to true to publish over plain HTTP only. This configures the optionWithHttpNoLibp2p
config.Ingest.PublisherKind
is set to "dtsync", a warning is logged.