feat: http publisher without fully setting up server #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
force-pushed
the
rvagg/WithHttpPublisherWithoutServer
branch
2 times, most recently
from
9421d1f
to
b905b5c
Compare
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #382 +/- ##
==========================================
- Coverage 51.31% 50.91% -0.40%
==========================================
Files 61 61
Lines 4919 4959 +40
==========================================
+ Hits 2524 2525 +1
- Misses 2085 2118 +33
- Partials 310 316 +6
☔ View full report in Codecov by Sentry. |
gammazero
force-pushed
the
rvagg/WithHttpPublisherWithoutServer
branch
from
a12a09e
to
a008694
Compare
gammazero
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: ipni/go-libipni#56
No tests in here yet. Not sure how best to go about doing that.
This allows
Engineto be used in a more passive move via HTTP. Set it up, attach it to an existing server, and let it run. See. https://github.com/ipld/go-frisbii for how I'm using this, currently with forks of both engine and httpsync to make it work.