Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove commands that are now implemented in ipni-cli #366

Merged
merged 2 commits into from
May 25, 2023

Conversation

gammazero
Copy link
Collaborator

Let's not maintain the same functionality in multiple places.

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: +7.81 🎉

Comparison is base (70c0368) 43.72% compared to head (8380bc9) 51.53%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #366      +/-   ##
==========================================
+ Coverage   43.72%   51.53%   +7.81%     
==========================================
  Files          70       60      -10     
  Lines        5654     4853     -801     
==========================================
+ Hits         2472     2501      +29     
+ Misses       2878     2049     -829     
+ Partials      304      303       -1     
Impacted Files Coverage Δ
cmd/provider/list.go 0.00% <0.00%> (ø)
cmd/provider/provider.go 0.00% <ø> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@masih masih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@gammazero gammazero merged commit db6aab9 into main May 25, 2023
@gammazero gammazero deleted the move-cmds-ipni-cli branch May 25, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants