Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Godoc explicitly mentions gossipsub whereas that's not necessarily true #387

Closed
masih opened this issue Jul 4, 2023 · 1 comment · Fixed by #420
Closed

Godoc explicitly mentions gossipsub whereas that's not necessarily true #387

masih opened this issue Jul 4, 2023 · 1 comment · Fixed by #420

Comments

@masih
Copy link
Member

masih commented Jul 4, 2023

Go docs below specifically callout gossipsub whereas how the announcements are sent entirely depends on engine config.

index-provider/engine/engine.go

Line 221 in faa8568

// first, then publishes a message onto the gossipsub to signal the change in

gammazero added a commit that referenced this issue Oct 23, 2023
@gammazero
Update comment
4bd431b 
Fixex #387
@gammazero gammazero mentioned this issue Oct 23, 2023
Merged
gammazero added a commit that referenced this issue Oct 23, 2023
@gammazero
Update comment (#420)
57bab77 
Fixex #387
@gammazero
Copy link
Collaborator

Fixed by #420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update comment ipni/index-provider
2 participants
@masih @gammazero