Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

[WIP] Refactor all IPLD specifications #72

Merged
merged 19 commits into from
Nov 8, 2018
Merged

Conversation

mikeal
Copy link
Contributor

@mikeal mikeal commented Sep 28, 2018

Following up on the new direction I've started to refactor the specifications.

Based on comments by @diasdavid I'm also removing the out of date or deprecated specs as I go.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Codecs/DAG-JSON.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@lanzafame
Copy link

lanzafame commented Oct 19, 2018 via email

@mikeal
Copy link
Contributor Author

mikeal commented Nov 5, 2018

Ok, just pushed lots of fixes.

I'd like to move this towards a merge. It isn't perfect, but it's a lot closer to how we're now talking about IPLD than the current state of the repo.

@mikeal
Copy link
Contributor Author

mikeal commented Nov 5, 2018

@diasdavid I disagreed with the codec/format terminology and you haven't responded to my prior reply so I resolved that conversation for now. If you want to continue to discuss we can start a new thread, PR, or we can just have a quick call to resolve it.

Copy link
Member

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, though I can also open issues if you want to merge without making any changes.

Codecs/DAG-CBOR.md Show resolved Hide resolved
IPLD-Path.md Show resolved Hide resolved
IPLD-Path.md Show resolved Hide resolved
IPLD-Path.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
IPLD-Data-Model-v1.md Outdated Show resolved Hide resolved
IPLD-Path.md Show resolved Hide resolved
IPLD.md Show resolved Hide resolved
Copy link
Member

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it's ready to be merged, further changes can be discussed on separate issues.

README.md Outdated Show resolved Hide resolved
@mikeal
Copy link
Contributor Author

mikeal commented Nov 8, 2018

Ok, I think we're ready to merge now. All pending discussions have been closed.

@mikeal
Copy link
Contributor Author

mikeal commented Nov 8, 2018

What teams have merge access in this repo?

@vmx
Copy link
Member

vmx commented Nov 8, 2018

@mikeal I've added the IPLD JS Team.

@mikeal mikeal merged commit acf0a5f into ipld:master Nov 8, 2018
prataprc pushed a commit to iprs-dev/ipld-specs that referenced this pull request Oct 13, 2020
Retcon of all IPLD specifications.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants