Derive common traits for DagCborCodec
#32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Derive Copy, Clone, Debug, PartialEq, and Eq
Closed
vmx
approved these changes
Apr 22, 2024
This was referenced Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks 👋
I'm upgrading some of my WIP IPLD libraries to
ipld-core, and have found a few things that I think may be helpful upstream rather than just writing my own versions plus conversions.This one is a small change to derive
Copy,Clone,Debug,PartialEq, andEq. Some of the tools I'm writing do automatic encoding/decoding into theIplddata model, and so I need to be able to pass around the codec in a config struct. This is difficult in many places without at leastCopyorClone.If this PR is accepted, I can do the same for
DagJsonCodecandDagPbCodec.Thanks 😃🦀