This repository has been archived by the owner on Aug 11, 2021. It is now read-only.
update dependencies for js-ipfs 0.33 #166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f1c2e12. This breaking change will be applied once the dependencies are updated.
A new version of interface-datastore is needed for the js-ifps 0.33 release.
daviddias
reviewed
Oct 25, 2018
| @@ -18,12 +18,12 @@ const MemoryStore = require('interface-datastore').MemoryDatastore | |||
| function noop () {} | |||
|
|
|||
| class IPLDResolver { | |||
| constructor (options) { | |||
| if (!options.blockService) { | |||
| constructor (blockService) { | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is needed for js-ipfs/pull/1617.
This PR also reverts one breaking change. This makes things easier as then I can do a patch release without the need to keep separate branches.
This supersedes #165.
/cc @ vasco-santos