Skip to content
This repository has been archived by the owner on Aug 24, 2021. It is now read-only.

fix: order tree directory entries correctly (fixes #44) #45

Merged
merged 1 commit into from
Mar 27, 2019

Conversation

sameer
Copy link
Contributor

@sameer sameer commented Mar 22, 2019

Added a trailing / when entries are directories for sorting.
Two test entries are added similar to those in #44 to confirm the fix.

@codecov
Copy link

codecov bot commented Mar 22, 2019

Codecov Report

Merging #45 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
+ Coverage   92.03%   92.11%   +0.07%     
==========================================
  Files           7        7              
  Lines         314      317       +3     
==========================================
+ Hits          289      292       +3     
  Misses         25       25
Impacted Files Coverage Δ
src/util/tree.js 94.59% <100%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4519644...ae6432b. Read the comment docs.

Copy link
Member

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could you @magik6k please have a look, you know more about Git than me :)

src/util/tree.js Show resolved Hide resolved
@vmx vmx merged commit 02be41f into ipld:master Mar 27, 2019
@sameer sameer deleted the fixtreeorder branch March 27, 2019 14:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants