Skip to content
This repository has been archived by the owner on Aug 24, 2021. It is now read-only.

Update multicodec to the latest version 🚀 #34

Closed
wants to merge 1 commit into from

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Dec 18, 2018

The dependency multicodec was updated from 0.2.7 to 0.3.0.

This version is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.


Release Notes for v0.3.0

Bug Fixes

Chores

BREAKING CHANGES

  • 'murmur3' is now called 'murmur3-128'
Commits

The new version differs by 7 commits.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

greenkeeper bot added a commit that referenced this pull request Jan 8, 2019
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Jan 8, 2019

  • The dependency multicodec was updated from 0.2.7 to 0.4.0.

Update to this version instead 🚀

Release Notes for v0.4.0
  • Revert "feat: make adding a custom codec possible" (9e251ce)

Chores

  • fully automatic table generation (f3d8c0d)

BREAKING CHANGES

  • multibase is not part of this package anymore

As multibase works differently from multicodec, those codecs
were removed from the multicodec table, hence those are also
removed from this implementation as we have automatic
conversion from the upstream table.

  • the addCodec() function is removed

The addCodec() function is removed as it doesn't work as expected.
Things break as soon as the module is loaded several times, which
can happen if dependencies require a different version.

Steps to reproduce this problem:

$ mkdir addcodecbug
$ cd addcodecbug
$ npm install cids@0.5.7 multicodec@0.3.0
npm WARN saveError ENOENT: no such file or directory, open '/tmp/addcodecbug/package.json'
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN enoent ENOENT: no such file or directory, open '/tmp/addcodecbug/package.json'
npm WARN addcodecbug No description
npm WARN addcodecbug No repository field.
npm WARN addcodecbug No README data
npm WARN addcodecbug No license field.

+ multicodec@0.3.0
+ cids@0.5.7
added 10 packages from 35 contributors and audited 14 packages in 1.363s
found 0 vulnerabilities
$ cat > index.js <<'EOF'
// Uses multicodec v0.2.7
const CID = require('cids')
// Imports multicodec v0.3.0
const multicodec = require('multicodec')

multicodec.addCodec('my-codec', Buffer.from('5566', 'hex'))
// Works, the codec was added
console.log(multicodec.getCodeVarint('my-codec'))

const multihash = Buffer.from(
'1220b94d27b9934d3e08a52e52d7da7dabfac484efe37a5380ee9088f7ace2efcde9',
'hex')
const cid = new CID(1, 'my-codec', multihash)
console.log(cid)
// Fails as my-codec was only added to the multicodec module loaded by this
// file, and not the one loaded by cids.
console.log(cid.toBaseEncodedString())
EOF
$ node index.js
<Buffer e6 aa 01>
CID {
codec: 'my-codec',
version: 1,
multihash:
<Buffer 12 20 b9 4d 27 b9 93 4d 3e 08 a5 2e 52 d7 da 7d ab fa c4 84 ef e3 7a 53 80 ee 90 88 f7 ac e2 ef cd e9> }
/tmp/addcodecbug/node_modules/cids/node_modules/multicodec/src/index.js:76
throw new Error('Codec ' + codecName + ' not found')
^

Error: Codec my-codec not found
at Object.exports.getCodeVarint (/tmp/addcodecbug/node_modules/cids/node_modules/multicodec/src/index.js:76:11)
at ClassIsWrapper.get buffer [as buffer] (/tmp/addcodecbug/node_modules/cids/src/index.js:131:22)
at ClassIsWrapper.toBaseEncodedString (/tmp/addcodecbug/node_modules/cids/src/index.js:202:44)
at Object.<anonymous> (/tmp/addcodecbug/index.js:17:17)
at Module._compile (internal/modules/cjs/loader.js:702:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:713:10)
at Module.load (internal/modules/cjs/loader.js:612:32)
at tryModuleLoad (internal/modules/cjs/loader.js:551:12)
at Function.Module._load (internal/modules/cjs/loader.js:543:3)
at Function.Module.runMain (internal/modules/cjs/loader.js:744:10)

Commits

The new version differs by 4 commits.

  • 8bc09e4 chore: release version v0.4.0
  • b6d3ffb chore: update contributors
  • f3d8c0d chore: fully automatic table generation
  • 9e251ce Revert "feat: make adding a custom codec possible"

See the full diff

@ghost ghost assigned vmx Jan 8, 2019
@ghost ghost added the status/in-progress In progress label Jan 8, 2019
@vmx vmx closed this in #37 Jan 8, 2019
vmx pushed a commit that referenced this pull request Jan 8, 2019
@ghost ghost removed the status/in-progress In progress label Jan 8, 2019
@greenkeeper greenkeeper bot deleted the greenkeeper/multicodec-0.3.0 branch January 8, 2019 18:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant