This repository has been archived by the owner on Aug 11, 2021. It is now read-only.
fix: support CIDs in DAGLink #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
vmx
approved these changes
Jul 31, 2018
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
==========================================
+ Coverage 90.8% 90.87% +0.06%
==========================================
Files 13 13
Lines 272 274 +2
==========================================
+ Hits 247 249 +2
Misses 25 25
Continue to review full report at Codecov.
|
This was referenced Aug 1, 2018
alanshaw
added a commit
to ipfs/js-ipfs
that referenced
this pull request
Aug 15, 2018
This PR contains fixes for the test failures that are happening in master for `object.patch.rmLink`. I **think** this change ipld/js-ipld-dag-pb#80 made `DAGLink` validate the hash better and caused the failures to start. It also contains fixes for the `pinSet` module which was using the "private" `_multihash` property which was removed in ipld/js-ipld-dag-pb#81 and released 2 days ago - don't use private APIs kids. License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a minimal change to support CIDs in a DAGLink. This allows things like traversing through from a dag-pb directory to a git tree
We should really rename the property from
mutlihashtocid, but that is breaking change. I'd be up for adding an additional cid property and deprecatingmutlihashtho.Fixes #79
License: MIT
Signed-off-by: Oli Evans oli@tableflip.io