This repository has been archived by the owner on Aug 11, 2021. It is now read-only.
fix: pass serialized blob to util.cid #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: the first argument is now the serialized output NOT the dag node. See ipld/interface-ipld-format#32
vmx
approved these changes
Jun 26, 2018
src/util.js
Outdated
| @@ -19,14 +20,15 @@ exports = module.exports | |||
| /** | |||
| * Get the CID of the DAG-Node. | |||
| * | |||
| * @param {Object} dagNode - Internal representation | |||
| * @param {Buffer} blob - Serialized binary data | |||
There was a problem hiding this comment.
I would change it to Encoded Protocol Buffers blob or Serialized as Protocol Buffers.
src/util.js
Outdated
| @@ -19,14 +20,15 @@ exports = module.exports | |||
| /** | |||
| * Get the CID of the DAG-Node. | |||
There was a problem hiding this comment.
Perhaps it should say Get CID of Protocol Buffers encoded node?
richardschneider
added a commit
that referenced
this pull request
Jun 27, 2018
This reverts commit 2ae9542.
richardschneider
added a commit
that referenced
this pull request
Jun 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: the first argument is now the serialized output NOT the dag node.
See ipld/interface-ipld-format#32