This repository has been archived by the owner on Aug 11, 2021. It is now read-only.
Make cid() work on binary blobs
#24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of having `util.cid()` take a DAG node as input, change it to take a binary blob as input. This can save some (de)serializtion overhead. It also gains optional options for specifying a CID version and the hash algorithm that should be used for calculation (if you don't want to use the default one).
Stebalien
approved these changes
Apr 17, 2018
This was referenced Apr 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having
util.cid()take a DAG node as input, change itto take a binary blob as input. This can save some (de)serializtion
overhead.
It also gains optional options for specifying a CID version and the
hash algorithm that should be used for calculation (if you don't
want to use the default one).