Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bindnode): add a BindnodeRegistry utility #437

Merged
merged 4 commits into from
Jun 24, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
160 changes: 160 additions & 0 deletions node/bindnode/registry/registry.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,160 @@
package registry

import (
"fmt"
"io"
"reflect"

"github.com/ipld/go-ipld-prime"
"github.com/ipld/go-ipld-prime/codec"
"github.com/ipld/go-ipld-prime/datamodel"
"github.com/ipld/go-ipld-prime/node/bindnode"
"github.com/ipld/go-ipld-prime/schema"
)

type prototypeData struct {
proto schema.TypedPrototype
options []bindnode.Option
}

// BindnodeRegistry holds TypedPrototype and bindnode options for Go types and
// will use that data for conversion operations.
type BindnodeRegistry map[reflect.Type]prototypeData

// NewRegistry creates a new BindnodeRegistry
func NewRegistry() BindnodeRegistry {
return make(BindnodeRegistry)
}

func typeOf(ptrValue interface{}) reflect.Type {
val := reflect.ValueOf(ptrValue).Type()
for val.Kind() == reflect.Ptr {
val = val.Elem()
}
return val
}

func (br BindnodeRegistry) prototypeDataFor(ptrType interface{}) prototypeData {
typ := typeOf(ptrType)
proto, ok := br[typ]
if !ok {
panic(fmt.Sprintf("bindnode utils: type has not been registered: %s", typ.Name()))
}
return proto
}

// RegisterType registers ptrType with schema such that it can be wrapped and
// unwrapped without needing the schema, Type, or TypedPrototype.
// Typically the typeName will match the Go type name, but it can be whatever
// is defined in the schema for the type being registered.
// Registering the same type twice on this registry will cause an error.
// This call may also error if the schema is invalid or the type doesn't match
// the schema. Additionally, panics from within bindnode's initial prototype
// checks will be captured and returned as errors from this function.
func (br BindnodeRegistry) RegisterType(ptrType interface{}, schema string, typeName string, options ...bindnode.Option) (err error) {
typ := typeOf(ptrType)
if _, ok := br[typ]; ok {
return fmt.Errorf("bindnode utils: type already registered: %s", typ.Name())
}
typeSystem, err := ipld.LoadSchemaBytes([]byte(schema))
if err != nil {
return fmt.Errorf("bindnode utils: failed to load schema: %s", err.Error())
}
schemaType := typeSystem.TypeByName(typeName)
if schemaType == nil {
return fmt.Errorf("bindnode utils: schema for [%T] does not contain that named type [%s]", ptrType, typ.Name())
}

// focusing on bindnode setup panics
defer func() {
if rec := recover(); rec != nil {
switch v := rec.(type) {
case string:
err = fmt.Errorf(v)
case error:
err = v
default:
panic(rec)
}
}
}()

proto := bindnode.Prototype(ptrType, schemaType, options...)
br[typ] = prototypeData{
proto,
options,
}

return err
}

// IsRegistered can be used to determine if the type has already been registered
// within this registry.
// Using RegisterType on an already registered type will cause a panic, so where
// this may be the case, IsRegistered can be used to check.
func (br BindnodeRegistry) IsRegistered(ptrType interface{}) bool {
_, ok := br[typeOf(ptrType)]
return ok
}

// TypeFromReader deserializes bytes using the given codec from a Reader and
// instantiates the Go type that's provided as a pointer via the ptrValue
// argument.
func (br BindnodeRegistry) TypeFromReader(r io.Reader, ptrValue interface{}, decoder codec.Decoder) (interface{}, error) {
protoData := br.prototypeDataFor(ptrValue)
node, err := ipld.DecodeStreamingUsingPrototype(r, decoder, protoData.proto)
if err != nil {
return nil, err
}
typ := bindnode.Unwrap(node)
return typ, nil
}

// TypeFromBytes deserializes bytes using the given codec from its bytes and
// instantiates the Go type that's provided as a pointer via the ptrValue
// argument.
func (br BindnodeRegistry) TypeFromBytes(byts []byte, ptrValue interface{}, decoder codec.Decoder) (interface{}, error) {
protoData := br.prototypeDataFor(ptrValue)
node, err := ipld.DecodeUsingPrototype(byts, decoder, protoData.proto)
if err != nil {
return nil, err
}
typ := bindnode.Unwrap(node)
return typ, nil
}

// TypeFromNode converts an datamodel.Node into an appropriate Go type that's
// provided as a pointer via the ptrValue argument.
func (br BindnodeRegistry) TypeFromNode(node datamodel.Node, ptrValue interface{}) (interface{}, error) {
protoData := br.prototypeDataFor(ptrValue)
if tn, ok := node.(schema.TypedNode); ok {
node = tn.Representation()
}
builder := protoData.proto.Representation().NewBuilder()
err := builder.AssignNode(node)
if err != nil {
return nil, err
}
typ := bindnode.Unwrap(builder.Build())
return typ, nil
}

// TypeToNode converts a Go type that's provided as a pointer via the ptrValue
// argument to an schema.TypedNode.
func (br BindnodeRegistry) TypeToNode(ptrValue interface{}) schema.TypedNode {
protoData := br.prototypeDataFor(ptrValue)
return bindnode.Wrap(ptrValue, protoData.proto.Type(), protoData.options...)
}

// TypeToWriter is a utility method that serializes a Go type that's provided as
// a pointer via the ptrValue argument through the given codec to a Writer.
func (br BindnodeRegistry) TypeToWriter(ptrValue interface{}, w io.Writer, encoder codec.Encoder) error {
return ipld.EncodeStreaming(w, br.TypeToNode(ptrValue), encoder)
}

// TypeToBytes is a utility method that serializes a Go type that's provided as
// a pointer via the ptrValue argument through the given codec and returns the
// bytes.
func (br BindnodeRegistry) TypeToBytes(ptrValue interface{}, encoder codec.Encoder) ([]byte, error) {
return ipld.Encode(br.TypeToNode(ptrValue), encoder)
}
100 changes: 100 additions & 0 deletions node/bindnode/registry/registry_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,100 @@
package registry_test

import (
"bytes"
"encoding/hex"
"math"
"testing"

"github.com/ipld/go-ipld-prime/codec/dagcbor"
"github.com/ipld/go-ipld-prime/codec/dagjson"
"github.com/ipld/go-ipld-prime/node/basicnode"
"github.com/ipld/go-ipld-prime/node/bindnode"
"github.com/ipld/go-ipld-prime/node/bindnode/registry"

qt "github.com/frankban/quicktest"
)

type HexString string
type Foo struct {
Int int
Bool bool
}

func TestRegistry(t *testing.T) {
reg := registry.NewRegistry()
qt.Assert(t, reg.IsRegistered((*Foo)(nil)), qt.IsFalse)
qt.Assert(t, reg.IsRegistered((*HexString)(nil)), qt.IsFalse)

err := reg.RegisterType((*Foo)(nil),
`type Foo struct {
Int Int
Bool Bool
}`, "Foo")
qt.Assert(t, err, qt.IsNil)

err = reg.RegisterType((*HexString)(nil), "type HS bytes", "HS", bindnode.TypedBytesConverter(
(*HexString)(nil),
func(b []byte) (interface{}, error) {
return HexString(hex.EncodeToString(b)), nil
},
func(i interface{}) ([]byte, error) {
s, _ := i.(*HexString)
return hex.DecodeString(string(*s))
}))
qt.Assert(t, err, qt.IsNil)

qt.Assert(t, reg.IsRegistered((*Foo)(nil)), qt.IsTrue)
qt.Assert(t, reg.IsRegistered((*HexString)(nil)), qt.IsTrue)

hsi, err := reg.TypeFromNode(basicnode.NewBytes([]byte{0, 1, 2, 3, 4}), (*HexString)(nil))
qt.Assert(t, err, qt.IsNil)
hs, ok := hsi.(*HexString)
qt.Assert(t, ok, qt.IsTrue)
qt.Assert(t, string(*hs), qt.Equals, "0001020304")

byts, _ := hex.DecodeString("a263496e74386364426f6f6cf4")
fooi, err := reg.TypeFromBytes(byts, (*Foo)(nil), dagcbor.Decode)
qt.Assert(t, err, qt.IsNil)
foo, ok := fooi.(*Foo)
qt.Assert(t, ok, qt.IsTrue)
qt.Assert(t, *foo, qt.Equals, Foo{Int: -100, Bool: false})

byts, err = reg.TypeToBytes(&Foo{Int: -100, Bool: false}, dagjson.Encode)
qt.Assert(t, err, qt.IsNil)
qt.Assert(t, string(byts), qt.Equals, `{"Bool":false,"Int":-100}`)

byts, _ = hex.DecodeString("a263496e741a7fffffff64426f6f6cf5")
fooi, err = reg.TypeFromReader(bytes.NewReader(byts), (*Foo)(nil), dagcbor.Decode)
qt.Assert(t, err, qt.IsNil)
foo, ok = fooi.(*Foo)
qt.Assert(t, ok, qt.IsTrue)
qt.Assert(t, *foo, qt.Equals, Foo{Int: math.MaxInt32, Bool: true})

w := bytes.Buffer{}
err = reg.TypeToWriter(&Foo{Int: math.MaxInt32, Bool: true}, &w, dagjson.Encode)
qt.Assert(t, err, qt.IsNil)
qt.Assert(t, w.String(), qt.Equals, `{"Bool":true,"Int":2147483647}`)
}

func TestRegistryErrors(t *testing.T) {
reg := registry.NewRegistry()
err := reg.RegisterType((*Foo)(nil), `type Nope nope {}`, "Foo")
qt.Assert(t, err, qt.ErrorMatches, `.*unknown type keyword: "nope".*`)

err = reg.RegisterType((*HexString)(nil), "type HS string", "HS")
qt.Assert(t, err, qt.IsNil)

err = reg.RegisterType((*HexString)(nil), "type HS2 string", "HS2")
qt.Assert(t, err, qt.ErrorMatches, `.*type already registered: HexString`)

err = reg.RegisterType((*Foo)(nil), "type NotFoo string", "Foo")
qt.Assert(t, err, qt.ErrorMatches, `.*does not contain that named type.*`)

err = reg.RegisterType((*Foo)(nil),
`type Foo struct {
NotInt String
NotBool Float
}`, "Foo")
qt.Assert(t, err, qt.ErrorMatches, `.*kind mismatch.*`)
}