Allow using WalkOption in WriteCar function #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willscott
approved these changes
Jan 28, 2023
|
I think the general sentiment has been to encourage additional feature development to happen in the v2 branch. Since this is backwards compatible / minor, and since we have continued to maintain the v1 branch I don't see any strong objection to merging. |
Jorropo
pushed a commit
to ipfs/boxo
that referenced
this pull request
Mar 22, 2023
Allow using WalkOption in WriteCar function This commit was moved from ipld/go-car@bfc8d73
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass through the
merkledag.WalkOptionparameters to the underlyingmerkledag.Walk()function.This is helpful for a number of use-cases, in particular it allows creating a CAR with missing nodes. E.g., currently it's not possible to create a CAR with raw links pointing to CIDs not present in the local blockstore. After this change, you can use the following: