feat: extract TraversalResumerPathState interface and allow it to be shared across traversals #327
+268
−152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think if we allowed for a stored/shared
TraversalResumerPathState
(interface forpathState
) then we should be able to resume across any selective CAR that has the same selector & DAG.For the purpose of Boost, we'd make one of these things, then share it across any CAR creation that happens, accumulating state and allowing the
Seek()
to move forward in the CAR, skipping over blocks that don't interfere the traversal and that don't need.The catch for Boost is that it needs to be thread safe, so we'd need to wrap it all in a mutex, but we can do that over there.