Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-ipld-prime to the era of NodeAssembler. #31

Merged
merged 2 commits into from
Apr 29, 2020
Merged

Conversation

warpfork
Copy link
Contributor

Bumps dependencies and updates a few interfaces and package names that have shifted lately.

go mod did a lot of other things that make very little sense to me -- the two commands I ran were go get github.com/ipld/go-ipld-prime@master and go get github.com/ipld/go-ipld-prime-proto@master, and how that caused go-ipld-format to show up in the update effects (it's a test dependency only of a transitive lib, afaict?), or why lots of other things appear in the the 'go.sum' file that are even more distantly (un)related and also get many versions recorded which we haven't actually handled... I... I don't know. Someone may want to sanity check that; it's clear I simply don't understand why go mod is trying to do, and probably disagree with it in any case. But tests pass; so, I think the update overall is passable.

@codecov
Copy link

codecov bot commented Apr 29, 2020

Codecov Report

Merging #31 into master will decrease coverage by 0.08%.
The diff coverage is 63.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
- Coverage   55.91%   55.83%   -0.09%     
==========================================
  Files           3        3              
  Lines         279      283       +4     
==========================================
+ Hits          156      158       +2     
- Misses         88       89       +1     
- Partials       35       36       +1     
Impacted Files Coverage Δ
selectivecar.go 68.54% <63.63%> (-0.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15dcd72...12ce672. Read the comment docs.

Copy link

@ribasushi ribasushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality looks good to me. You may want to go mod tidy - there will be a notable shrinkage of go.sum as a result ( go.mod should remain intact )

@warpfork
Copy link
Contributor Author

Fascinatingly, that:

  • networked, again (which I would hold is fundamentally inappropriate for the requested operation)
  • removed some things
  • added even more things???? (if these hashes weren't encountered or important before, how did they become encountered, much less become important, during "tidy"????)

I've committed the results. However, these behaviors strike me as not so much minor bugs as they are boggling infirmities of core concepts -- seeing a system that appears to use hashes, but also does so in such inconsistent ways that one begins to wonder if those hashes are being checked or actually mean anything is deeply disquieting and something I have an especially strong allergy to. I formally give up trying to reason about go mod. It does not spark joy.

@warpfork warpfork merged commit c222d79 into master Apr 29, 2020
@warpfork warpfork deleted the update-ipld-libs branch April 29, 2020 20:09
@aschmahmann aschmahmann mentioned this pull request Sep 22, 2020
72 tasks
Jorropo pushed a commit to ipfs/boxo that referenced this pull request Mar 22, 2023
Update go-ipld-prime to the era of NodeAssembler.

This commit was moved from ipld/go-car@c222d79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants