Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate car/ cli into cmd/car #233

Merged
merged 2 commits into from
Sep 14, 2021
Merged

integrate car/ cli into cmd/car #233

merged 2 commits into from
Sep 14, 2021

Conversation

willscott
Copy link
Member

  • Flesh out the verify command with v2 checks
  • The list command is already present
  • Removes the header command that previously printed out a json representation of a header. It's unclear what we got from that and what we want to have that do with v2 files. I believe the functionality should be largely maintained, and would prefer to either print relevant data as part of verify or add an inspect command that provides info on both the v2 and v1 metadata if we decide there is important functionality to maintain there.

Flesh out the verify command
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 ftr I'm not convinced of the utility of verify either, your call on what to remove, as long as we get rid of the old main then this is good by me

@willscott
Copy link
Member Author

I think i imagine keeping verify as a baseline for testing that mutation sub-commands generate reasonable output

@willscott willscott merged commit 4fd3550 into master Sep 14, 2021
@willscott willscott deleted the verify branch September 14, 2021 07:15
@aschmahmann aschmahmann mentioned this pull request Dec 1, 2021
80 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants