Add carve utility for updating the index of a car{v1,v2} file #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdan
reviewed
Sep 7, 2021
masih
requested changes
Sep 7, 2021
carve/carve.go
Outdated
| Aliases: []string{"i"}, | ||
| Usage: "write out the car with an index", | ||
| Action: func(c *cli.Context) error { | ||
| r, err := carv2.OpenReader(c.Args().Get(0)) |
There was a problem hiding this comment.
Would be nice to have a named flag for this, e.g. -i
There was a problem hiding this comment.
i think this is fine as a positional argument
carve/carve.go
Outdated
|
|
||
| outStream := os.Stdout | ||
| if c.Args().Len() >= 2 { | ||
| outStream, err = os.Create(c.Args().Get(1)) |
There was a problem hiding this comment.
Would be nice to have a named flag for this, e.g. -o
carve/carve.go
Outdated
| } | ||
| defer r.Close() | ||
|
|
||
| var idx index.Index |
There was a problem hiding this comment.
We may have been given a CARv2 that has the desired index already; would it make sense to check for that and skip extra work if not needed?
There was a problem hiding this comment.
i think in this context i'm fine without that optimization
masih
approved these changes
Sep 7, 2021
|
I'm noting that running: from the I wonder if that means this isn't striding over blocks properly / ends up misaligned in the v1 case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run as
carve index -c CarMultihashIndexSorted test.car