Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline all data files #85

Open
UmanShahzad opened this issue Nov 10, 2023 · 1 comment
Open

Inline all data files #85

UmanShahzad opened this issue Nov 10, 2023 · 1 comment

Comments

@UmanShahzad
Copy link
Contributor

We have several files like eu.json, countries.json, continents.json and so on, which are loaded during initialization / startup of the client.

Instead of loading these as such, which has risks such as the asset not appearing in a production environment properly, and has a performance penalty during init of loading an on-disk file, we should inline the files into a static, in-memory map / dictionary or similar.

@UmanShahzad
Copy link
Contributor Author

@Shoaib-Ashfaq FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant