Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove prism #21

Merged
merged 3 commits into from
Nov 13, 2023
Merged

feat!: remove prism #21

merged 3 commits into from
Nov 13, 2023

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Nov 13, 2023

Fixes #19.

It seems like we're using prism for the syntax highlighting, which seems to have had similar issues with other languages. It looks a lot like an upstream issue.

We decided to remove prism for now and when time allows to replace by https://highlightjs.org/.

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hacdias ! Smoke-tested and fixes #19, fine to ship:

Before

2023-11-13_14-02

With this fix

2023-11-13_14-02_1

@hacdias hacdias merged commit 626e905 into main Nov 13, 2023
@hacdias hacdias deleted the remove-prism branch November 13, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Escaping of quotes and <> in code blocks is broken
2 participants