feat(http-routers): filter-protocols from IPIP-484 #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gammazero
approved these changes
Oct 15, 2024
| delegatedRouter, err := delegatedHTTPContentRouter(endpoint, | ||
| routingv1client.WithHTTPClient(httpClient), | ||
| routingv1client.WithProtocolFilter(cfg.RoutingV1FilterProtocols), // IPIP-484 | ||
| routingv1client.WithStreamResultsRequired(), // https://specs.ipfs.tech/routing/http-routing-v1/#streaming |
There was a problem hiding this comment.
Out of scope for this PR, but...
According to the docs,
server MAY respond with non-streaming application/json response even if the client requested streaming
So, would his option be better named WithStreamResultsRequested or WithStreamResultsAccepted?
There was a problem hiding this comment.
Yes, imo the name is confusing and redundant.
The default accepts both here, and specs says you should always return JSON as fallback anyway.
(afaik this config was onl yadded because cid.contact errored on streaming requests, but it was fixed since then)
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is Rainbow version of ipfs/kubo#10534 which adds support for
filter-protocolsfrom IPIP-484 and makes Rainbow useunknown+transport-bitswapas implicit default.The intention here is to skip peers which are not actionable.