Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gateway): support for IPIP-402 CAR params #9881

Closed
wants to merge 1 commit into from
Closed

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented May 17, 2023

Superseded by #9914.

@hacdias
Copy link
Member Author

hacdias commented May 17, 2023

@aschmahmann it seems that the current update already broke some CAR tests! I think it's related to the additional blocks we now have for path traversal. Not sure though.

@aschmahmann
Copy link
Contributor

aschmahmann commented May 17, 2023

Yeah, probably a combination of things like extra blocks and changing the name of the output CAR file in the Content-Disposition header.

@hacdias hacdias force-pushed the boxo/ipip-402 branch 3 times, most recently from 179cc2e to a440aab Compare May 31, 2023 15:15
@hacdias
Copy link
Member Author

hacdias commented Jun 1, 2023

Superseded by #9914.

@hacdias hacdias closed this Jun 1, 2023
@hacdias hacdias deleted the boxo/ipip-402 branch June 1, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants