Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky content routing over HTTP test #9772

Merged
merged 2 commits into from
Apr 5, 2023
Merged

test: fix flaky content routing over HTTP test #9772

merged 2 commits into from
Apr 5, 2023

Conversation

guseggert
Copy link
Contributor

This sharness test is flaky, so porting to Go.

@guseggert guseggert force-pushed the test/port-content-routing-http branch 5 times, most recently from 0b424ab to c3763f6 Compare March 30, 2023 12:05
@guseggert guseggert requested a review from Jorropo March 30, 2023 12:05
@guseggert guseggert marked this pull request as ready for review March 30, 2023 12:06
@guseggert guseggert force-pushed the test/port-content-routing-http branch from c3763f6 to a23f5b3 Compare March 30, 2023 15:09
@guseggert guseggert self-assigned this Mar 30, 2023
@guseggert guseggert force-pushed the test/port-content-routing-http branch from a23f5b3 to 69fcf70 Compare March 30, 2023 20:58
Jorropo
Jorropo reviewed Mar 31, 2023
View reviewed changes
test/cli/content_routing_http_test.go Outdated Show resolved Hide resolved
test/cli/content_routing_http_test.go Outdated Show resolved Hide resolved
@guseggert guseggert force-pushed the test/port-content-routing-http branch 5 times, most recently from 79f8044 to f288540 Compare April 4, 2023 18:06
@guseggert guseggert requested a review from Jorropo April 4, 2023 18:06
@guseggert guseggert force-pushed the test/port-content-routing-http branch from f288540 to bba11bd Compare April 4, 2023 18:08
@guseggert guseggert changed the title test: port content routing over HTTP sharness test test: fix flaky content routing over HTTP test Apr 4, 2023
@hacdias hacdias force-pushed the test/port-content-routing-http branch from 63f63aa to f47ca8d Compare April 5, 2023 10:58
hacdias
hacdias approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@hacdias hacdias left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a small cleanup (to use httptest.Server and remove an unnecessary require). Everything else LGTM. I'll merge once it's ✅

@hacdias hacdias force-pushed the test/port-content-routing-http branch from f47ca8d to ce5e795 Compare April 5, 2023 11:01
@hacdias hacdias enabled auto-merge (squash) April 5, 2023 11:09
@hacdias hacdias merged commit fd830b3 into master Apr 5, 2023
@hacdias hacdias deleted the test/port-content-routing-http branch April 5, 2023 11:10
@lidel lidel mentioned this pull request May 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hacdias hacdias hacdias approved these changes

@Jorropo Jorropo Awaiting requested review from Jorropo

Assignees

@guseggert guseggert

Labels
None yet
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guseggert @hacdias @Jorropo