Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clarity: no user supplied rcmgr limits of 0 #9563

Commits on Jan 19, 2023

  1. Clarity: no user supplied rcmgr limits of 0

    The goal of this commit is to make clear that we don't support user-supplied limits of 0 currently.
    Apply (https://github.com/libp2p/go-libp2p/blob/master/p2p/host/resource-manager/limit.go#L102 ) overrides any 0 value.  
    With the current code, a zero-limit in userSuppliedOverrideLimitConfig will be overridden by the computed default limits.
    
    I want to be able to do:
    
    ```
    defaultComputedLimitConfig.Apply(userSuppliedOverrideLimitConfig)
    ```
    
    but that won't override any of the computed defaults.
    
    I'd like to see this fixed, but this at least make clear the situation.
    BigLep authored Jan 19, 2023
    Configuration menu
    Copy the full SHA
    754c74e View commit details
    Browse the repository at this point in the history
  2. Update rcmgr.go

    BigLep authored Jan 19, 2023
    Configuration menu
    Copy the full SHA
    25c3118 View commit details
    Browse the repository at this point in the history
  3. Update rcmgr.go

    BigLep authored Jan 19, 2023
    Configuration menu
    Copy the full SHA
    b14b1e3 View commit details
    Browse the repository at this point in the history
  4. Update core/node/libp2p/rcmgr.go

    Co-authored-by: Antonio Navarro Perez <antnavper@gmail.com>
    BigLep and ajnavarro authored Jan 19, 2023
    Configuration menu
    Copy the full SHA
    ea0055a View commit details
    Browse the repository at this point in the history
  5. Update config.md

    BigLep authored Jan 19, 2023
    Configuration menu
    Copy the full SHA
    1562af8 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2023

  1. Whitespace formatting

    BigLep committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    0d103e9 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2023

  1. Merge branch 'master' into fix/clarity-resource-mgr-user-overrides-wi…

    …th-zero-values-not-supported
    lidel authored Jan 21, 2023
    Configuration menu
    Copy the full SHA
    12126ab View commit details
    Browse the repository at this point in the history