feat: fast directory listings with DAG Size column #9481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacdias
commented
Dec 8, 2022
hacdias
force-pushed
the
refactor/9058
branch
2 times, most recently
from
8b9ff9a
to
233ff43
Compare
hacdias
changed the title
hacdias
changed the title
Jorropo
reviewed
Dec 8, 2022
Jorropo
reviewed
Dec 8, 2022
hacdias
force-pushed
the
refactor/9058
branch
from
c58e7b8
to
1a654df
Compare
hacdias
changed the title
hacdias
force-pushed
the
refactor/9058
branch
2 times, most recently
from
d280dc3
to
845ebef
Compare
hacdias
force-pushed
the
refactor/9058
branch
from
ed39e37
to
f3f0ec7
Compare
We've just introduced JSON and CBOR support, and need additional work to figure put how to communicate these options in a way that leverages verifiable CAR over untrusted TARs. Removing them for now.
lidel
changed the title
lidel
changed the title
lidel
approved these changes
Dec 12, 2022
There was a problem hiding this comment.
LGTM, merging for inclusion in Kubo 0.18.0-rc1 (so the sizes here match Tsize from ?format=json)
- Removed "Preview as" and "Download as" buttons as discussed today – we don't want to announce these features widely yet, probably need proper designer to prototype / refresh dir listing before we add them.
- Confirmed that the removed optional field does not crash clients that had it defined manually
- Switched to released dependency
- Added release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9058.
Checklist
Use.Dag.Getinstead of.Unixfs.Lsto fetch the directories (take into consideration sharded)Unixfs.LswithUseCumulativeSizeto use the DAG Size, but skip remaining calculations. See comment.Gateway.FastDirIndexThresholdoption as it is no longer relevantAdd "Preview as" and "Download as" buttons to the listing header with multiple formats.descoped for nowLoads
bafybeiggvykl7skb2ndlmacg2k5modvudocffxjesexlod2pfvg5yhwrqm(10k items) extremely fast, and with size!