Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve ResourceManager UX #9338

Merged
merged 14 commits into from
Nov 10, 2022
Merged

feat: Improve ResourceManager UX #9338

merged 14 commits into from
Nov 10, 2022

Commits on Nov 10, 2022

  1. Improve ErrorManager UX 

    This PR adds several new functionalities to make easier the usage of
ResourceManager:

- Now resource manager logs when resources are exceeded are on ERROR
  instead of warning.
- The resources exceeded error now show what kind of limit was reached
- When there was no limit exceeded, we print a message for the user
  saying that limits were back to normal
- Added `swarm limit all` command to show all set limits with the same
  format as `swarm stats all`
- Added `min-used-limit-perc` option to `swarm stats all` to only show
  stats that are above a specific percentage
    @ajnavarro
    ajnavarro committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    6c482af View commit details
    Browse the repository at this point in the history

  2. Improve log output and fix stat.Peers output bug

    @ajnavarro
    ajnavarro committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    86b5dd8 View commit details
    Browse the repository at this point in the history

  3. Requested changes

    @ajnavarro
    ajnavarro committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    6ba5a15 View commit details
    Browse the repository at this point in the history

  4. Simplify ResourceManager defaults. 

    Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
    @ajnavarro
    ajnavarro committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    e75b570 View commit details
    Browse the repository at this point in the history

  5. Improve error messages and tweak default values. 

    Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
    @ajnavarro
    ajnavarro committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    46f6ab3 View commit details
    Browse the repository at this point in the history

  6. Go mod tidy 

    Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
    @ajnavarro
    ajnavarro committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    d2b8da1 View commit details
    Browse the repository at this point in the history

  7. Enable ResourceManager by default.

    @ajnavarro
    ajnavarro committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    c8d28b3 View commit details
    Browse the repository at this point in the history

  8. Fix rcmgr logging test 

    Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
    @ajnavarro
    ajnavarro committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    1f09608 View commit details
    Browse the repository at this point in the history

  9. Fix shaness tests 

    Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
    @ajnavarro
    ajnavarro committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    3fc3d99 View commit details
    Browse the repository at this point in the history

  10. Requested changes. 

    Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
    @ajnavarro
    ajnavarro committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    fb881ba View commit details
    Browse the repository at this point in the history

  11. go mod tidy 

    Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
    @ajnavarro
    ajnavarro committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    d844df9 View commit details
    Browse the repository at this point in the history

  12. Use file descriptors only on unix. 

    Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
    @ajnavarro
    ajnavarro committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    e7c9800 View commit details
    Browse the repository at this point in the history

  13. Requested changes 

    Signed-off-by: Antonio Navarro <antnavper@gmail.com>
    @ajnavarro
    ajnavarro committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    f730347 View commit details
    Browse the repository at this point in the history

  14. Fix getFD on Windows 

    Signed-off-by: Antonio Navarro <antnavper@gmail.com>
    @ajnavarro
    ajnavarro committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    f9b7a79 View commit details
    Browse the repository at this point in the history