Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix broken ENS DoH example #9281

Merged
merged 3 commits into from
Sep 20, 2022

Conversation

eth-limo
Copy link
Contributor

This PR adds documentation for using eth.limo as an alternative DoH resolver for eth. domains.

@Jorropo
Copy link
Contributor

Jorropo commented Sep 16, 2022

@eth-limo thx a lot, this is good, would you be ok with your resolver be a fallback resolver for eth by default ?
(note I'll have to discuss with other maintainers before doing this change)

@eth-limo
Copy link
Contributor Author

@eth-limo thx a lot, this is good, would you be ok with your resolver be a fallback resolver for eth by default ? (note I'll have to discuss with other maintainers before doing this change)

Yeah absolutely, that sounds good to us.

@ipfs ipfs deleted a comment from welcome bot Sep 20, 2022
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: there is no point in having a separate paragraph about ENS, the point that custom resolvers can be specified per TLD is already made by existing docs.

@eth-limo given the current state of affairs around eth.link, mind replacing the broken https://eth.link/dns-query in the preexisting example with https://dns.eth.limo/dns-query and call it a day?

This is not the first, not the second, and not the third time the eth.link proven to be unreliable. Let's remove it from our docs.

@lidel lidel changed the title Provide documentation for alternate eth. resolution docs: fix broken ENS DoH example Sep 20, 2022
@eth-limo
Copy link
Contributor Author

nit: there is no point in having a separate paragraph about ENS, the point that custom resolvers can be specified per TLD is already made by existing docs.

@eth-limo given the current state of affairs around eth.link, mind replacing the broken https://eth.link/dns-query in the preexisting example with https://dns.eth.limo/dns-query and call it a day?

This is not the first, not the second, and not the third time the eth.link proven to be unreliable. Let's remove it from our docs.

@lidel thank you for the suggestion. This is complete.

@lidel lidel enabled auto-merge (squash) September 20, 2022 22:28
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lidel lidel merged commit 8e2bf82 into ipfs:master Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants