fix: holepunch in go-libp2p 0.19.2 #8966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lidel was there a test you were thinking we should be re-enabling here now that we have this fix? |
marten-seemann
approved these changes
May 12, 2022
|
@aschmahmann I created #8967 to investigate that separately – 0.19.2 does not seem to fix it. |
This was referenced May 16, 2022
Closed
guseggert
pushed a commit
that referenced
this pull request
Jun 8, 2022
guseggert
pushed a commit
that referenced
this pull request
Jun 8, 2022
https://github.com/libp2p/go-libp2p/releases/tag/v0.19.2 (cherry picked from commit 657d4f4)
guseggert
pushed a commit
that referenced
this pull request
Jun 8, 2022
https://github.com/libp2p/go-libp2p/releases/tag/v0.19.2 (cherry picked from commit 657d4f4)
guseggert
pushed a commit
that referenced
this pull request
Jun 8, 2022
https://github.com/libp2p/go-libp2p/releases/tag/v0.19.2 (cherry picked from commit 657d4f4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://github.com/libp2p/go-libp2p/releases/tag/v0.19.2