Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename to kubo #8958

Merged
merged 4 commits into from
Jul 6, 2022
Merged

refactor: rename to kubo #8958

merged 4 commits into from
Jul 6, 2022

Conversation

lidel
Copy link
Member

@lidel lidel commented May 9, 2022

Why rename?

Please see ipfs/ipfs#470 and #8959

Why kubo?

Please see #8959 (it was picked by both devs and community).

Rationale for this PR

Renaming to "banana" until a better name comes along.

ipfs-banana

In all seriousness, this PR aims to identify the minimal surface we need to change before July, given the limited bandwidth IPFS Stewards have.

TODO

Part of #8959 – see it for the full context

@lidel lidel mentioned this pull request May 9, 2022
11 tasks
@lidel lidel self-assigned this May 9, 2022
@lidel lidel force-pushed the chore/rename-to-banana branch 2 times, most recently from fce44e1 to 9149d6e Compare May 9, 2022 22:20
@hello-smile6

This comment was marked as resolved.

@hello-smile6

This comment was marked as resolved.

@jbenet
Copy link
Member

jbenet commented May 26, 2022

i love it ❤️

@jbenet
Copy link
Member

jbenet commented May 26, 2022

@lidel might work

image

.circleci/main.yml Outdated Show resolved Hide resolved
@lidel lidel changed the title chore: rename to ipfs-banana refactor: rename to kubo Jun 19, 2022
@lidel lidel changed the title refactor: rename to kubo refactor: rename to b̶a̶n̶a̶n̶a̶ kubo Jun 21, 2022
@lidel lidel changed the title refactor: rename to b̶a̶n̶a̶n̶a̶ kubo refactor: rename to b̵̵̵a̵̵̵n̵̵̵a̵̵̵n̵̵̵a̵̵̵ kubo Jun 21, 2022
@lidel lidel changed the title refactor: rename to b̵̵̵a̵̵̵n̵̵̵a̵̵̵n̵̵̵a̵̵̵ kubo refactor: rename to b̶a̶n̶a̶n̶a̶ kubo Jun 21, 2022
@lidel
Copy link
Member Author

lidel commented Jun 21, 2022

Pushed 6086a70 with minimal refactor that allows our Docker image publishing machine to work and publish the same image under both names:

$ ./bin/get-docker-tags.sh $(date -u +%F) 88d88158c master
ipfs/kubo:master-2022-06-21-88d8815
ipfs/go-ipfs:master-2022-06-21-88d8815
ipfs/kubo:master-latest
ipfs/go-ipfs:master-latest

(For now we keep go-ipfs in docs. We will switch docs to use kubo after we have the first release 0.14)

👉 @aschmahmann @BigLep @guseggert I think this is ready for review – the sooner we merge this and rename the repo, the more time we have to fix things that WILL break before July.

👉 ⚠️ If we need to make any go-ipfs 0.13.1 patch release, it should happen before we merge this.

@lidel lidel marked this pull request as ready for review June 21, 2022 13:15
@lidel lidel added this to the kubo 0.14 milestone Jun 21, 2022
@lidel lidel changed the title refactor: rename to b̶a̶n̶a̶n̶a̶ kubo refactor: rename to kubo Jul 6, 2022
lidel added 4 commits July 6, 2022 18:40
some things like third party package names, docker image etc need to
stay as go-ipfs for now
This ensures we keep publishing the same image under both names:

    $ ./bin/get-docker-tags.sh $(date -u +%F) 88d8815 master                                                                                                                                 ...chore/rename-to-banana
    ipfs/kubo:master-2022-06-21-88d8815
    ipfs/go-ipfs:master-2022-06-21-88d8815
    ipfs/kubo:master-latest
    ipfs/go-ipfs:master-latest
@lidel lidel merged commit d82dec3 into master Jul 6, 2022
@lidel lidel deleted the chore/rename-to-banana branch July 6, 2022 17:00
hacdias pushed a commit to ipfs/boxo that referenced this pull request Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants