Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use path instead of filepath for asset embeds to support Windows #8944

Merged
merged 1 commit into from
May 5, 2022

Conversation

aschmahmann
Copy link
Contributor

@aschmahmann aschmahmann commented May 4, 2022

fixes #8943.

Note: CI won't help us here because we don't really have any Windows testing 😢.

Copy link
Member

@ajnavarro ajnavarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on a windows virtual machine:

PS C:\Users\User> .\ipfs.exe init
generating ED25519 keypair...done
peer identity: 12D3KooWQEsJXdLxdst5a2CtaaMChvHAkTUAkjDFqmyuTdpqhkvL
initializing IPFS node at C:\Users\User\.ipfs
to get started, enter:

        ipfs cat /ipfs/QmQPeNsJPyVWPFDVHb77w8G42Fvo15z4bG2X8D2GhfbSXc/readme

PS C:\Users\User> ./ipfs.exe cat /ipfs/QmQPeNsJPyVWPFDVHb77w8G42Fvo15z4bG2X8D2GhfbSXc/readme
Hello and Welcome to IPFS!

██╗██████╗ ███████╗███████╗
██║██╔══██╗██╔════╝██╔════╝
██║██████╔╝█████╗  ███████╗
██║██╔═══╝ ██╔══╝  ╚════██║
██║██║     ██║     ███████║
╚═╝╚═╝     ╚═╝     ╚══════╝

If you're seeing this, you have successfully installed
IPFS and are now interfacing with the ipfs merkledag!

 -------------------------------------------------------
| Warning:                                              |
|   This is alpha software. Use at your own discretion! |
|   Much is missing or lacking polish. There are bugs.  |
|   Not yet secure. Read the security notes for more.   |
 -------------------------------------------------------

Check out some of the other files in this directory:

  ./about
  ./help
  ./quick-start     <-- usage examples
  ./readme          <-- this file
  ./security-notes
PS C:\Users\User>

@aschmahmann aschmahmann merged commit 1299bcb into master May 5, 2022
@aschmahmann aschmahmann deleted the fix/embed-assets-windows branch May 5, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ipfs init error on Windows: Error loading seed assets
2 participants