Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gw): extract logical functions to improve readability #8855

Closed
wants to merge 1 commit into from
Closed

chore(gw): extract logical functions to improve readability #8855

wants to merge 1 commit into from
+108 −63

Conversation

justindotpub
Copy link
Contributor

@lidel if you approve, this is an initial PR with some cleanup before implementing any redirects support.

@justindotpub justindotpub requested a review from lidel as a code owner April 7, 2022 14:09
@justindotpub justindotpub mentioned this pull request Apr 7, 2022
Closed
@justindotpub justindotpub force-pushed the justincjohnson/redirects-refactoring-1 branch from 957fc24 to ec10aa3 Compare April 12, 2022 12:46
chore: gateway_handler.go
01bd73c 
Extract functions from getOrHeadHandler to improve readability and prepare for later refactorings
@justindotpub justindotpub force-pushed the justincjohnson/redirects-refactoring-1 branch from ec10aa3 to 01bd73c Compare April 12, 2022 13:30
@lidel lidel changed the title chore(gateway): Extract functions from getOrHeadHandler to improve readability chore(gw): extract logical functions to improve readability Apr 13, 2022
@lidel lidel mentioned this pull request Apr 13, 2022
Closed
3 tasks
@lidel
Copy link
Member

lidel commented Apr 13, 2022 •
edited
Loading

@justincjohnson permissions at fission-suite org make it very difficult to review your PRs:

  • CircleCI does not run because of your org permissions
  • I am not able to push small cleanups

To work around this, I am closing this PR and re-opening as upstream branch in #8883 – let's continue there.

Not sure how to avoid these problems In the future 🤔
Would it be possible for you to open PRs from your personal account?
It should fix both CI and review papercuts. 🙏

@lidel lidel closed this Apr 13, 2022
@justindotpub
Copy link
Contributor Author

No problem @lidel. Sorry for the bumps that have made this review process more painful.

@justindotpub
Copy link
Contributor Author

@lidel Fission prefers that we work on branches in our org. By any chance are the CircleCI permission issues documented somewhere and something we could just fix on our end, or are there other problems caused by us working in our own org? Thanks.

@lidel
Copy link
Member

lidel commented Apr 14, 2022

@justincjohnson not aware of any docs, this seems to be uncharted teritory. You could see if https://app.circleci.com/ allows you to enable CircleCI on your go-ipfs fork repo. Perhaps that will solve the problem?

@justindotpub justindotpub mentioned this pull request Apr 20, 2022
Closed
@lidel lidel mentioned this pull request Apr 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel Awaiting requested review from lidel lidel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justindotpub @lidel