Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add CODEOWNERS #8852

Merged
merged 1 commit into from
Apr 6, 2022
Merged

chore: add CODEOWNERS #8852

merged 1 commit into from
Apr 6, 2022

Conversation

lidel
Copy link
Member

@lidel lidel commented Apr 6, 2022

This adds CODEOWNERS file which automatically asks specific people for a review when specific paths are modified as a part of a PR.

To be specific, I've added myself, because I'd like to follow gateways changes.

This adds CODEOWNERS file which automatically asks specific people for
a review when specific paths are modified as a part of a PR.
@lidel lidel added this to the go-ipfs 0.13 milestone Apr 6, 2022
Copy link
Contributor

@aschmahmann aschmahmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM. I'm not sure how widely applicable this will be, certainly makes sense for gateway code though and if we find more use then great!

Copy link
Contributor

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting started. Looks good!

@BigLep BigLep merged commit dd06dd0 into master Apr 6, 2022
@BigLep BigLep deleted the chore/add-codeowners-file branch April 6, 2022 16:14
@lidel
Copy link
Member Author

lidel commented Apr 6, 2022

You can see demo in #8816 (PR draft):

2022-04-07_00-26

Pretty cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants