Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): look for MFS root in local repo only #8661

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

schomatis
Copy link
Contributor

Closes #7183. (The bigger issue of GC/MFS lock is being worked on independently. We close the issue about hanging on startup.)

@BigLep BigLep removed the request for review from Stebalien March 3, 2022 13:38
@BigLep BigLep added this to the Best Effort Track milestone Mar 3, 2022
@BigLep
Copy link
Contributor

BigLep commented Mar 11, 2022

@aschmahmann will approve/merge

Copy link
Contributor

@aschmahmann aschmahmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we should have a small sharness test that confirms that this works.

@schomatis
Copy link
Contributor Author

I tested this locally with the new command in #8648. That seems like the most organic way to add a sharness test for this so will mark it as blocked on that other one (feel free to suggest an alternative test that would keep both independent).

@lidel lidel force-pushed the schomatis/fix/core/mfs-root-localy-only branch from d2cae12 to 131a4e1 Compare June 21, 2024 15:10
@lidel lidel requested a review from a team as a code owner June 21, 2024 15:10
@lidel lidel force-pushed the schomatis/fix/core/mfs-root-localy-only branch from 131a4e1 to 6d31769 Compare June 21, 2024 17:04
@lidel lidel added the skip/changelog This change does NOT require a changelog entry label Oct 3, 2024
@lidel lidel merged commit 22aeb13 into master Oct 3, 2024
14 of 15 checks passed
@lidel lidel deleted the schomatis/fix/core/mfs-root-localy-only branch October 3, 2024 19:38
@lidel lidel mentioned this pull request Oct 3, 2024
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does NOT require a changelog entry
Projects
No open projects
Status: 🛑 Blocked
Development

Successfully merging this pull request may close these issues.

Ipfs daemon hangs when MFS root is not available locally
5 participants