feat(cmds): allow to set the configuration file path #8634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guseggert
reviewed
Feb 15, 2022
schomatis
force-pushed
the
schomatis/feat/cmds/use-custom-config-file-path
branch
from
f64d1b0
to
0764066
Compare
|
@guseggert : can you do the final review/merge so we can close this out? |
guseggert
reviewed
Mar 7, 2022
go.mod
Outdated
Comment on lines
34
to
35
| // FIXME(BLOCKING): Update to release tag once https://github.com/ipfs/go-ipfs-config/pull/162 lands. | ||
| github.com/ipfs/go-ipfs-config v0.19.1-0.20220221223623-ea7b3a0b7fba |
| return &FSRepo{path: expPath}, nil | ||
| configFilePath, err := config.Filename(rpath, userConfigFilePath) | ||
| if err != nil { | ||
| // FIXME: Personalize this when the user config path is "". |
There was a problem hiding this comment.
Not blocking, just a normal FIXME, can remove if you want.
This comment was marked as resolved.
This comment was marked as resolved.
schomatis
force-pushed
the
schomatis/feat/cmds/use-custom-config-file-path
branch
3 times, most recently
from
5fa000a
to
34356a1
Compare
guseggert
approved these changes
Mar 11, 2022
|
Can you add a sharness test covering these new flags? |
|
@guseggert : it says you approved the changes but I see you've also requested a sharness test. To make it clear, do you want to adjust your review to "request changes"? |
guseggert
requested changes
Mar 14, 2022
schomatis
force-pushed
the
schomatis/feat/cmds/use-custom-config-file-path
branch
from
34356a1
to
3f4c0df
Compare
|
Not sure what are the |
It's a known issue, we can ignore |
guseggert
approved these changes
Mar 29, 2022
|
@schomatis : can you rebase please? That will fix CI and then we can merge. |
schomatis
force-pushed
the
schomatis/feat/cmds/use-custom-config-file-path
branch
from
ec9bcec
to
9a8cb13
Compare
schomatis
force-pushed
the
schomatis/feat/cmds/use-custom-config-file-path
branch
from
9a8cb13
to
e172ad2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First iteration, still incomplete. Review needed at this point to move forward.
Depends on ipfs/go-ipfs-config#162.
Closes #8067.