Add config flag to cmd line interface #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Made some comments, otherwise LGTM. |
|
though one meta comment is that maybe instead of specifying the config file, we should be specifying the ipfs root ( Though this has different semantics, so idk. Advantage of config file flag is that potentially there are installations that require nothing but the config file (i.e. don't need a whole directory). I think: let's merge this in and keep the above ^ in consideration for the future. |
ribasushi
pushed a commit
that referenced
this pull request
Jul 4, 2021
fix: correctly add the skip option to Warningf
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Feb 25, 2022
…/multiformats/go-multiaddr-0.2.2 chore(deps): bump github.com/multiformats/go-multiaddr from 0.2.1 to 0.2.2
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Feb 25, 2022
…dules/github.com/multiformats/go-multiaddr-0.2.2 chore(deps): bump github.com/multiformats/go-multiaddr from 0.2.1 to 0.2.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.