change ipfs dag get flag name from format to output-codec #8440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschmahmann
commented
Sep 15, 2021
core/commands/dag/dag.go
Outdated
| @@ -109,7 +109,7 @@ format. | |||
| cmds.StringArg("ref", true, false, "The object to get").EnableStdin(), | |||
| }, | |||
| Options: []cmds.Option{ | |||
| cmds.StringOption("format", "f", "Format that the object will be serialized as.").WithDefault("dag-json"), | |||
| cmds.StringOption("codec", "c", "Format that the object will be encoded as.").WithDefault("dag-json"), | |||
There was a problem hiding this comment.
"c" is used for the global --config. We can either not use a shortcut or come up with a different name/leave things as is.
There was a problem hiding this comment.
I don't think short notation adds value here, I'm for just removing it (see #8439 (comment) for rationale)
There was a problem hiding this comment.
Going to remove the shortcut and change to --output-codec to clarify that the stored data is being transcoded per #8439 (comment).
aschmahmann
force-pushed
the
feat/change-dag-get-flag-name
branch
3 times, most recently
from
6a8a51b
to
a18c9b4
Compare
aschmahmann
force-pushed
the
feat/change-dag-get-flag-name
branch
from
a18c9b4
to
49058c2
Compare
aschmahmann
force-pushed
the
feat/change-dag-get-flag-name
branch
from
49058c2
to
d576e53
Compare
aschmahmann
commented
Sep 27, 2021
| format, _ := req.Options["format"].(string) | ||
| var fCodec mc.Code | ||
| if err := fCodec.Set(format); err != nil { | ||
| codecStr, _ := req.Options["output-codec"].(string) |
There was a problem hiding this comment.
This lack of error handling seems wrong, although this pattern is all over the commands lib usage so likely not too big a problem
aschmahmann
changed the base branch from
master
to
feat/change-dag-put-flag-names
aschmahmann
changed the title
guseggert
approved these changes
Sep 27, 2021
This was referenced Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
ipfs dag get --formattoipfs dag get --output-codecto be closer to #8439.TODO: Merge to master after #8439