chore: update go-path #8436
Merged
chore: update go-path #8436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschmahmann
force-pushed
the
chore/update-go-path
branch
from
d055f68
to
c0d9703
Compare
aschmahmann
force-pushed
the
chore/update-go-path
branch
2 times, most recently
from
bf9430c
to
37c6ab8
Compare
aschmahmann
force-pushed
the
chore/update-go-path
branch
from
37c6ab8
to
294e5b0
Compare
aschmahmann
commented
Sep 23, 2021
aschmahmann
commented
Sep 23, 2021
Comment on lines
+65
to
+66
| // Note: we could just check a particular path here, but it would require either greater use of the HAMT internals | ||
| // or some hard coded values in the test both of which would be a pain to follow. |
There was a problem hiding this comment.
This makes the test take a couple of seconds to run, which is a bit annoying if we were going to run many of these although not so bad by itself.
aschmahmann
commented
Sep 23, 2021
Comment on lines
+73
to
+75
| if timeoutCtx.Err() == nil { | ||
| t.Fatal(err) | ||
| } |
There was a problem hiding this comment.
This is one of the reasons I chose to do this instead of a sharness test (the other being the sharness tests are less portable which is overall just no fun).
The equivalent sharness test would have to process text outputs like "context deadline exceeded" as good and "context cancelled" as bad which is a little too close for comfort and wouldn't detect other regressions where we returned "context deadline exceeded" in error.
3 tasks
aschmahmann
force-pushed
the
chore/update-go-path
branch
from
294e5b0
to
2c0019b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ipfs/go-path#44