Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump minimum go version to 1.15 #7944

Merged
merged 3 commits into from
May 12, 2021
Merged

chore: bump minimum go version to 1.15 #7944

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a62025
chore: bump minimum go version to 1.15
aschmahmann Feb 25, 2021
a81718f
bump dockerfile to Go 1.15.8
aschmahmann May 12, 2021
73e7e02
downgrade to 1.15.2
aschmahmann May 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ default_environment: &default_environment
executors:
golang:
docker:
- image: circleci/golang:1.14.4
- image: circleci/golang:1.15.2
working_directory: ~/ipfs/go-ipfs
environment:
<<: *default_environment
Expand All @@ -60,7 +60,7 @@ executors:
E2E_IPFSD_TYPE: go
dockerizer:
docker:
- image: circleci/golang:1.14.4
- image: circleci/golang:1.15.2
environment:
IMAGE_NAME: ipfs/go-ipfs
WIP_IMAGE_TAG: wip
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Note: when updating the go minor version here, also update the go-channel in snap/snapcraft.yml
FROM golang:1.14.4-buster
FROM golang:1.15.2-buster
LABEL maintainer="Steven Allen <steven@stebalien.com>"

# Install deps
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ PS> scoop install go-ipfs

### Build from Source

go-ipfs's build system requires Go 1.14.4 and some standard POSIX build tools:
go-ipfs's build system requires Go 1.15.2 and some standard POSIX build tools:

* GNU make
* Git
Expand All @@ -170,7 +170,7 @@ To build without GCC, build with `CGO_ENABLED=0` (e.g., `make build CGO_ENABLED=

#### Install Go

The build process for ipfs requires Go 1.14.4 or higher. If you don't have it: [Download Go 1.14+](https://golang.org/dl/).
The build process for ipfs requires Go 1.15.2 or higher. If you don't have it: [Download Go 1.15+](https://golang.org/dl/).

You'll need to add Go's bin directories to your `$PATH` environment variable e.g., by adding these lines to your `/etc/profile` (for a system-wide installation) or `$HOME/.profile`:

Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,4 +108,4 @@ require (
golang.org/x/sys v0.0.0-20210503173754-0981d6026fa6
)

go 1.14
go 1.15
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no inherent reason we have to do this I guess, but given we're no longer testing with 1.14 this seems reasonable. WDYT @Stebalien?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM!

2 changes: 1 addition & 1 deletion mk/golang.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# golang utilities
GO_MIN_VERSION = 1.14.4
GO_MIN_VERSION = 1.15.2
export GO111MODULE=on


Expand Down